fix #8980 - improve horizontal placement of tie endpoints #9077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2021
asattely
force-pushed
the
horizontal-tie-placement
branch
2 times, most recently
from
1cbbcdf to
9abaeda
Compare
|
fixed some codestyle stuff and a stupid mistake |
cbjeukendrup
reviewed
Sep 8, 2021
src/engraving/libmscore/tie.cpp
Outdated
| } | ||
|
|
||
| // adjust for ledger lines | ||
| if (startNote()->line() >= 8 || startNote()->line() <= 0) { |
There was a problem hiding this comment.
This assumes that the notes are on a normal 5 line staff. You actually need check sc->staff()->staffTypeForElement(sc)->lines() to get the real number of lines.
src/engraving/libmscore/tie.cpp
Outdated
| // ADJUST FOR COLLISIONS ---------------- | ||
|
|
||
| // adjust for ledger lines | ||
| if (endNote()->line() >= 8 || endNote()->line() <= 0) { |
There was a problem hiding this comment.
Nice catch! I'll adjust that tomorrow.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Backport of musescore#9077, part 1 and 2, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Backport of musescore#9077, part 1 and 2, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 11, 2021
Backport of musescore#9077, part 1 and 2, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 13, 2021
Backport of musescore#9077, part 1 and 2, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 14, 2021
Backport of musescore#9077, part 1 and 2, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 14, 2021
Backport of musescore#9077, part 1 and 2, fixes musescore#8980
asattely
force-pushed
the
horizontal-tie-placement
branch
from
772f9a6 to
9104394
Compare
adjusting for flag, dot, offset notehead, and ledger line
asattely
force-pushed
the
horizontal-tie-placement
branch
from
9104394 to
01d9cf6
Compare
Don't really need to test whether the note is above or below the staff since the adjustment will only occur if the ledger line's y value is similar to the tie's
|
rebased, and also fixed a small problem with ties being adjusted for dots on offset notes |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
oktophonie
approved these changes
Sep 20, 2021
RomanPudashkin
approved these changes
Sep 20, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 24, 2021
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2021
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 29, 2021
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 3, 2021
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 7, 2021
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Backport of musescore#9077, part 1, 2 and 3, fixes musescore#8980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #8980 Improve horizontal position of chord tie endpoints
Tie endpoints now adjust for offset noteheads, ledger lines, flags, and dots. This PR does not deal with the vertical placement of these ties; that will be a different issue popping up in the near future.