[MU3 Backend] Tweak staff hiding conditions for spanners #8527

iveshenry18 · 2021-07-05T20:11:16Z

Resolves: False positive mentioned in #8430

This commit tweaks the changes from commit 54ebee4 (which checks for
spanners when assessing staff emptiness) and ignores spanners that are
"system" spanners (such as voltas or system text). This prevents a
false-positive unhiding in the case of such system spanners.

Also, it prevents another false positive that occurred when a spanner
started on the first tick of the next system.

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system.

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

See musescore#8430 (review) and musescore#8527

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Duplicate of musescore#8527

Port of musescore#8430, part 2: Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Plus port of musescore#8527: This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred hen a spanner started on the first tick of the next system. Plus fixing a regression with hairpins, resulting in the next system's stafes to become unhidden

Port of musescore#8430, part 2: Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Plus port of musescore#8527: This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred hen a spanner started on the first tick of the next system. Plus fixing a regression with hairpins, resulting in the next system's staves to become unhidden

Port of musescore#8430, part 2: Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Plus port of musescore#8527: This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred hen a spanner started on the first tick of the next system. Plus fixing a regression with hairpins, resulting in the next system's staves to become unhidden.

This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred when a spanner started on the first tick of the next system. Backport of musescore#8527

Jojo-Schmitz mentioned this pull request Jul 6, 2021

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

vpereverzev approved these changes Jul 12, 2021

View reviewed changes

vpereverzev merged commit 7504aae into musescore:3.6.2_backend Jul 12, 2021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 13, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

93ade14

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

80e326b

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

ce901f7

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

3e8b376

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

1c7d314

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

ed5b342

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

ae85b36

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

b7fda1f

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

668c256

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

1ea7c65

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

5d3f877

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

4301a1d

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

16402be

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

fc42a5c

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz mentioned this pull request Sep 1, 2021

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

022c73a

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

2d7e866

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

9452836

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

41151b6

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz mentioned this pull request Mar 1, 2023

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023

Fix for voltas and system text lines after "ENG-54, part 2"

86d0397

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz mentioned this pull request Oct 11, 2023

Staff visibility #19679

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MU3 Backend] Tweak staff hiding conditions for spanners #8527

[MU3 Backend] Tweak staff hiding conditions for spanners #8527

iveshenry18 commented Jul 5, 2021

[MU3 Backend] Tweak staff hiding conditions for spanners #8527

[MU3 Backend] Tweak staff hiding conditions for spanners #8527

Conversation

iveshenry18 commented Jul 5, 2021