New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-19: Correctly omit instrument names #8326

Merged

vpereverzev merged 2 commits into musescore:3.6.2_backend from iveshenry18:ENG-19-instrument-label-removal

Jun 23, 2021

Contributor

iveshenry18 commented Jun 16, 2021 •

edited

Loading

Resolves: ENG-19: Instrument labels to be removed

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

It also adds inferencing for the Sibelius direct-export-specific case of should-be-omitted names of the form "P#".

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

oktophonie approved these changes

View reviewed changes

iveshenry18 added 2 commits

June 22, 2021 11:51


          ENG-19: Correctly omit instrument names

24d892e

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.


          Add inferencing for incorrect part names

5cadfae

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

iveshenry18 force-pushed the ENG-19-instrument-label-removal branch from 365591c to 5cadfae Compare

June 22, 2021 17:51

vpereverzev approved these changes

View reviewed changes

vpereverzev merged commit 8536de8 into musescore:3.6.2_backend

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

cea1bd8

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

cf748c6

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

7b42953

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

fe47f21

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

df3386f

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

a2c20aa

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz mentioned this pull request

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

7964a95

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

628df38

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

2846fe6

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

12103f8

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

296f61c

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

73391b3

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

4d2d47a

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

cf9f7b3

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

fb74b41

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

38a565f

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

1a054d8

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

d171136

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

f888b73

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

37c6a6c

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

367ce60

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

d3e4003

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

2a714b8

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

ccdbc58

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

f707b56

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

dc044ab

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

adc0ef7

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

25cec37

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

726dbe2

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

1b0cd6a

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

cd8639e

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

230ea1d

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

d02c492

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

abe99cf

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

1521c81

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

d6bdad3

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

217c3da

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

817ce18

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz mentioned this pull request

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

71bd1aa

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

e7df777

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

bdaa1bb

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

2253b73

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

1ca3030

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

9ac9a12

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

316b936

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Jojo-Schmitz mentioned this pull request

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-19: Correctly omit instrument names

4aceadc

Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.

Duplicate of musescore#8326, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing for incorrect part names

cf8d3d5

Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".

Duplicate of musescore#8326, part 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet