Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-56: Default-y order for other elements #8311

Merged
merged 1 commit into from
Jun 15, 2021
Merged

[MU3 Backend] ENG-56: Default-y order for other elements #8311

merged 1 commit into from
Jun 15, 2021

Conversation

iveshenry18
Copy link
Contributor

Resolves: ENG-56: Add default-y ordering for fretboard diagrams and other annotations

This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to a discussion,
from 2018 but consistent with most of the
editions I've seen.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@iveshenry18
ENG-56: Default-y order for other elements
f934929 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.
@vpereverzev vpereverzev merged commit 4f70603 into musescore:3.6.2_backend Jun 15, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
9fd5a90 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
8f4af54 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
8429bf4 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jun 29, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
6bbabd0 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
1fca761 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
6e9065f 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
3917cba 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
05b4098 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
b001f7e 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
97a593c 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
bda6b5e 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
c00531b 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
3729a60 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
d06b930 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
f900e0a 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
5df6c47 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
c6913e3 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
e03217f 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
7348a1b 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@iveshenry18 @Jojo-Schmitz
ENG-56: Default-y order for other elements
dc96a47 
This commit adds default-y-based ordering for other direction elements
as well as fretboard diagrams.

In addition, it reorders fretboard diagrams to be autoplaced under
tempo text and, by extension, under voltas. This is contrary to
https://musescore.org/en/node/279391, but consistent with most of the
editions I've seen.

Duplicate of musescore#8311
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request May 24, 2024
Merged
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 24, 2024
@Jojo-Schmitz
Fix mtests
c30059e 
2 of which came in via a backport of musescore#8530, the other 2 came in via a backport of musescore#8311 and musescore#8116, apparenrly neither have yet been ported to Mu4.
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request May 24, 2024
Merged
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 12, 2024
@Jojo-Schmitz
Fix mtests
35fb5e5 
2 of which came in via a backport of musescore#8530, the other 2 came in via a backport of musescore#8311 and musescore#8116, apparenrly neither have yet been ported to Mu4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpereverzev vpereverzev vpereverzev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iveshenry18 @vpereverzev