Update instruments.xml to sort Articulations and Channels #8289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run share/instruments/update_instruments_xml.py to fetch the latest version of the online spreadsheet. In this version, the ordering of articulations and channels has been made consistent across all instruments. Sorting is done according to the order in which channels and articulations are defined in the Basics tab of the online spreadsheet.
wizofaus
approved these changes
Jun 9, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 29, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 1, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 5, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 6, 2021
| <Channel name="pop"> | ||
| <!--MIDI: Bank 0, Prog 37; MS General: Pop Bass--> | ||
| <program value="37"/> <!--Slap Bass 2--> | ||
| </Channel> |
There was a problem hiding this comment.
This is wrong, accustic bass should not default to slap but to pizzicato
Whether that should be named ' pizzicato' or just fall back to 'normal', like fot ehe other bass guitars is another issue to consider.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 13, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Backport of musescore#8289, additionally fixing the order of channels for accustic bass and fixing an mtest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run share/instruments/update_instruments_xml.py to fetch the latest version of the online spreadsheet. In this version, the ordering of articulations and channels has been made consistent across all instruments. Sorting is done according to the order in which channels and articulations are defined in the Basics tab of the online spreadsheet.