Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-48: Crash caused by importing negative offset #8283

Merged
merged 1 commit into from
Jun 15, 2021
Merged

[MU3 Backend] ENG-48: Crash caused by importing negative offset #8283

merged 1 commit into from
Jun 15, 2021

Conversation

iveshenry18
Copy link
Contributor

Resolves: ENG-48: Incorrect interpretation of tempo/metronome mark destroys initial layout

Some faulty MusicXML files include directions with an offset that
points to a tick < 0. These successfully import, but then crash as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@iveshenry18
ENG-48: Crash caused by importing negative offset
6642241 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.
@iveshenry18 iveshenry18 changed the title ENG-48: Crash caused by importing negative offset [MU3 Backend] ENG-48: Crash caused by importing negative offset Jun 8, 2021
@vpereverzev vpereverzev merged commit 2c2dcab into musescore:3.6.2_backend Jun 15, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
66fda59 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
b769f06 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
607b2e0 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jun 29, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
06d6474 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 6, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
eb770b2 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
6be2436 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
9242afd 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
1eaeff6 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
5c18e86 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
921587a 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
298c632 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
d7fa6ce 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
52f6ce8 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
e977c7b 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
d3b639e 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
9644bfb 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
ce77c93 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
bba4e05 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
74cf5d4 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
a34d289 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@iveshenry18 @Jojo-Schmitz
ENG-48: Crash caused by importing negative offset
1cdd700 
Some faulty MusicXML files include directions with an offset that
points to a tick < 0. This imports, but then crashes as soon as any
command is done on that direction. This commit adds a check upon import
that truncates any negative offset with a larger magnitude than the
associated tick, preventing this issue in MusicXML import.

Duplicate of musescore#8283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpereverzev vpereverzev vpereverzev approved these changes

@oktophonie oktophonie oktophonie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iveshenry18 @oktophonie @vpereverzev