Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to reorder Format-Style menu #7997

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Allow users to reorder Format-Style menu #7997

merged 1 commit into from
Apr 28, 2021

Conversation

fauziew
Copy link
Contributor

@fauziew fauziew commented Apr 24, 2021

Resolves: https://musescore.org/en/node/272277

Format-Style menu is currently 37 item long, and finding an item is quite difficult.
Changing into alphabetical order may not be ideal for all users.
This PR allows users to customize the ordering of the menu

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@fauziew fauziew marked this pull request as draft April 24, 2021 11:26
@fauziew fauziew force-pushed the editstyle branch 2 times, most recently from e648352 to e5f2880 Compare April 24, 2021 12:27
@fauziew fauziew marked this pull request as ready for review April 24, 2021 12:29
@Jojo-Schmitz
Copy link
Contributor

Now squash everything into just one commit please

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 24, 2021 •
edited
Loading

Pitty that the CI workflows doesn't work, else you'd been told about any code style issues much more direct and complete

@fauziew fauziew force-pushed the editstyle branch 2 times, most recently from ae8c19e to dd79159 Compare April 24, 2021 14:53
@Jojo-Schmitz
Copy link
Contributor

@igorkorsukov mind to approve this first time contributor for running workflows?

@igorkorsukov
Copy link
Contributor

@igorkorsukov mind to approve this first time contributor for running workflows?

Done!

@Jojo-Schmitz
Copy link
Contributor

Darn, still code style issues, some I overlooked and some on which I gave wrong advice ;-)

@vpereverzev vpereverzev merged commit d083ca3 into musescore:master Apr 28, 2021
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request May 10, 2021
Closed
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 4, 2021
Closed
This was referenced Mar 12, 2022
Merged
Closed
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jojo-Schmitz Jojo-Schmitz Jojo-Schmitz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauziew @Jojo-Schmitz @igorkorsukov @vpereverzev