Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #319776: [MusicXML export] Invalid MusicXML will be generated if exported sheet contains tied cue notes #7935

Closed
wants to merge 1 commit into from
Closed

Fix #319776: [MusicXML export] Invalid MusicXML will be generated if exported sheet contains tied cue notes #7935

wants to merge 1 commit into from

Conversation

lvinken
Copy link
Contributor

@lvinken lvinken commented Apr 11, 2021

Resolves: https://musescore.org/en/node/319776

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.
Solved by adding a single if statement.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@lvinken
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
ab2413f 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a <tie> child element.
The reason is that <tie> is designed for sound information, but cue notes are silent.
Simply having a <tied> element under <notations> will be enough.
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Apr 11, 2021
Closed
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Apr 27, 2021
Merged
@Jojo-Schmitz
Copy link
Contributor

See #8019 for a port to master

@vpereverzev vpereverzev added the archived PRs that have gone stale but could potentially be revived in the future label Apr 28, 2021
@vpereverzev
Copy link
Member

3.x merges are closed now

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 11, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
f6d0abf 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request May 20, 2021
Merged
8 tasks
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
3ab3652 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
00f1f09 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
2bba58a 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
b38f3ad 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
65d3762 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
9746251 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
850edc9 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
23f5088 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
64f740d 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
c25d8e1 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
fa78e99 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
f8e0e23 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
ce8f220 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
bfec113 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
@lvinken lvinken deleted the 319776-musicxml-export-tied-cue-notes-3.x branch September 21, 2021 09:18
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
cc1d152 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@lvinken @Jojo-Schmitz
Fix #319776: [MusicXML export] Invalid MusicXML will be generated if …
6e1baec 
…exported sheet contains tied cue notes

MusicXML does not allow a cue note to have a child element.
The reason is that is designed for sound information, but cue notes are silent.
Simply having a element under will be enough.

Duplicate of musescore#7935, resp. backport ot musescore#8019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived PRs that have gone stale but could potentially be revived in the future
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvinken @Jojo-Schmitz @vpereverzev