Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4] fix #288937: Two voices each with an accidental #5003

Closed

Conversation

mattmcclinch
Copy link
Contributor

Resolves: https://musescore.org/en/node/288937.

Moving this block to the end of the loop allows for taking into account accidentals in other voices at the specified segment, instead of ignoring them.

@dmitrio95
Copy link
Contributor

Some tests are failing here

@igorkorsukov igorkorsukov changed the title fix #288937: Two voices each with an accidental [MU4] fix #288937: Two voices each with an accidental Feb 5, 2021
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Mar 11, 2021

Rebase needed. It apparently was meant for MuseScore 3 at the time it got PRed.
Test fail in a midi test, might just need to adjust the expectations in testGlissando-ref.txt
Crash with buffer overflow in guitarpro tests

@vpereverzev vpereverzev added the archived PRs that have gone stale but could potentially be revived in the future label May 5, 2021
@vpereverzev
Copy link
Member

Archived due to inactivity for a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived PRs that have gone stale but could potentially be revived in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants