-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #286900 MIDI input menu has no None option #4853
Conversation
This PR tries to symmetrize the behavior of midi input and output, so that midi input can be disabled while still having midi output. |
d64de08
to
de5ac5f
Compare
I updated the PR so that the default behavior is the same as the current one: a midi input device is automatically grabbed unless it is explicitly set to none in the preferences.
I think thorough tests are needed to see if I managed to cover all possible cases. |
By request, I am also adding some code lines which should prevent the automatic grabbing of the same MIDI device for both input and output. As before, real-life tests with actual MIDI devices are needed. |
From the tests (see the related issue), the "none" preference does not survive at the third launch of the application. I will further work on this. |
eac7bfd
to
24b55e8
Compare
The current implementation mainly works. |
24b55e8
to
f12cbf5
Compare
Rebase needed. |
f12cbf5
to
e8c7e67
Compare
3.x is closed for any changes |
No description provided.