Skip to content

Commit b5fd1a8

Browse files
committed
Fix fret diagram VS harmony interactions
1 parent b72a048 commit b5fd1a8

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

src/engraving/dom/fret.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1127,6 +1127,12 @@ bool FretDiagram::setProperty(Pid propertyId, const PropertyValue& v)
11271127
case Pid::FRET_FINGERING:
11281128
setFingering(v.value<std::vector<int> >());
11291129
break;
1130+
case Pid::VISIBLE:
1131+
setVisible(v.toBool());
1132+
if (m_harmony) {
1133+
m_harmony->setVisible(v.toBool());
1134+
}
1135+
break;
11301136
case Pid::EXCLUDE_VERTICAL_ALIGN: {
11311137
bool val = v.toBool();
11321138
setExcludeVerticalAlign(val);

src/engraving/editing/edit.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4024,13 +4024,6 @@ void Score::cmdDeleteSelection()
40244024
fretDiagram->undoChangeProperty(Pid::VISIBLE, false);
40254025
continue;
40264026
}
4027-
} else if (e->isFretDiagram()) {
4028-
FretDiagram* fretDiagram = toFretDiagram(e);
4029-
Harmony* harmony = fretDiagram->harmony();
4030-
if (harmony) {
4031-
undoChangeParent(harmony, fretDiagram->segment(), track2staff(fretDiagram->track()));
4032-
elSelectedAfterDeletion = harmony;
4033-
}
40344027
} else if (e->isHarmony()) {
40354028
Harmony* harmony = toHarmony(e);
40364029
if (harmony->parentItem()->isFretDiagram()) {

0 commit comments

Comments
 (0)