Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower target gets better results #5

Closed
karelbilek opened this issue Jul 3, 2017 · 2 comments
Closed

Lower target gets better results #5

karelbilek opened this issue Jul 3, 2017 · 2 comments

Comments

@karelbilek
Copy link
Contributor

(continuation of discussion here bitcoinjs/coinselect#13 (comment) )

When I was playing with my JS port, I found out that using "lower" target - only sum of the outputs, without the added costs of tx + outputs - I get better results.

When I tried it on your code, I get better results too. See my branch

https://github.com/runn1ng/CoinSelectionSimulator/commits/experiment_lowtarget

Yeah, it's probabilistic :), but I always get better results with the low target

You can try it yourself. What do you think is the issue, and what is the ideal target?

(By "target", I mean the value that is targeted with the branch search)

@murchandamus
Copy link
Owner

murchandamus commented Jul 3, 2017

It's obvious that a tighter window on the exact match would reduce the fee for the transactions created with a match. However, did you check how it affected the total number of exact matches? Didn't it increase the total fees over the whole simulation? Does it affect the variance of the input set?

@karelbilek
Copy link
Contributor Author

When I look on the output, the lower target actually produces more matches. Again you can just check out my branch and try that.

And yes I looked at total cost.

one.murch.bitcoin.coinselection.Wallet Type;total cost
SETRBnB L;71246242
SETRBnB H;73494584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants