Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: minor optimisations #405

Merged
merged 2 commits into from May 29, 2022
Merged

perf: minor optimisations #405

merged 2 commits into from May 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 29, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #405 (8cb09a9) into main (5715407) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   82.68%   82.68%   -0.01%     
==========================================
  Files         264      264              
  Lines       15239    15236       -3     
==========================================
- Hits        12601    12598       -3     
  Misses       2638     2638              
Impacted Files Coverage Δ
crates/mun_hir/src/resolve.rs 86.08% <100.00%> (+0.12%) ⬆️
crates/mun_hir/src/ty/infer.rs 79.55% <100.00%> (-0.10%) ⬇️
crates/mun_hir/src/ty/infer/place_expr.rs 88.88% <100.00%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5715407...8cb09a9. Read the comment docs.

@Wodann Wodann changed the title Miscellaneous cleanups misc: code cleanup May 29, 2022
@Wodann Wodann requested review from Wodann and baszalmstra May 29, 2022 13:01
Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is much appreciated. Always good to see some quality of life changes!

One comment: can you change your commit messages to follow: https://www.conventionalcommits.org/en/v1.0.0/ . “minor” is not a valid prefix, I think style or perf would be good here.

@Wodann Wodann changed the title misc: code cleanup perf: minor optimisations May 29, 2022
@Wodann Wodann merged commit 98bbeb7 into mun-lang:main May 29, 2022
@ghost ghost deleted the misc-cleanups branch May 29, 2022 13:35
@Wodann Wodann added this to the Mun v0.4.0 milestone Jul 8, 2022
@Wodann Wodann assigned ghost Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants