-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: early support for arrays #341
Conversation
7f0db17
to
52c7f15
Compare
Codecov Report
@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 87.16% 87.09% -0.07%
==========================================
Files 271 275 +4
Lines 29356 31046 +1690
==========================================
+ Hits 25588 27040 +1452
- Misses 3768 4006 +238
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
52c7f15
to
0f5d148
Compare
I would really like to support creating arrays from a Rust iterator. Something like: let mun_array: ArrayRef = runtime.construct_array::<i32>(vec![1,2,3,4,].into_iter()) However, this requires type references, because the type information of the array cannot be created. The type information has to be created and shared with the mun libraries. This requires type references. |
7d35a1b
to
6b9420c
Compare
6b9420c
to
35ddadc
Compare
6d1839d
to
bbe485b
Compare
Depends on #268 |
bbe485b
to
56e7249
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comments :)
85125a1
to
8abd1b7
Compare
feat: array memory mapping
For the rocket and spaceship logic, can all of tr updates not just happen in Mun? In theory, we only need to query their positions from Rust to draw them |
docs: add book chapter about arrays
Adds early support for arrays in Mun! Co-authored-by: Wodann <Wodann@users.noreply.github.com>
Adds support for arrays.
Missing feature:
Out of scope