Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaced overly complicated redirection rules with a simple hack #196

Merged
merged 1 commit into from
May 17, 2020

Conversation

baszalmstra
Copy link
Collaborator

This PR replaces the overly complex logic to make the documentation for v0.2 available under a subdirectory.

Instead of adding a base tag to the documentation this PR adds some simple javascript to add a trailing slash to a url if the url doesnt end in .html. That should fix our relative path issues.

It also removes the need for mdbook v0.4 so I reverted back to just downloading the binary. That should make our CI mucho faster.

As an added bonus I also added a github icon that links back this repo.

We also have to push these changes to release/v0.2.

Closes #195
Closes #190

@baszalmstra baszalmstra requested a review from Wodann May 17, 2020 11:11
@baszalmstra baszalmstra self-assigned this May 17, 2020
@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   82.94%   82.94%           
=======================================
  Files         163      163           
  Lines       11509    11509           
=======================================
  Hits         9546     9546           
  Misses       1963     1963           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c20b47...81ec598. Read the comment docs.

@baszalmstra baszalmstra merged commit 4ad3d45 into mun-lang:master May 17, 2020
@baszalmstra baszalmstra deleted the fix/book/relative_urls branch May 17, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Book: Broken anchor-links because of HTML base-tag Update to released version of mdBook 0.4.0
2 participants