Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(code_gen): add incremental compilation test #102

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Mar 25, 2020

For now this is limited to a split between group_ir and file_ir as a group currently exists of a single file. In the future we will need to test that changing one file doesn't cause regeneration of another file.

NOTE: Once we add support for multiple files, we need to do a second optimization round. file_ir depends on group_ir for usage of the DispatchTable, but this could potentially be optimised by adding an external LLVM function that MUST be inlined. If we succeed in this optimization, file_ir never has to be regenerated when another file's changes cause the group_ir to be updated.

@Wodann Wodann requested a review from baszalmstra March 25, 2020 11:17
@Wodann Wodann self-assigned this Mar 25, 2020
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #102 into master will increase coverage by 0.09%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   77.78%   77.87%   +0.09%     
==========================================
  Files         134      134              
  Lines        8806     8833      +27     
==========================================
+ Hits         6850     6879      +29     
+ Misses       1956     1954       -2     
Impacted Files Coverage Δ
crates/mun_codegen/src/test.rs 97.50% <87.50%> (-2.50%) ⬇️
crates/mun_codegen/src/mock.rs 100.00% <100.00%> (ø)
crates/mun_hir/src/ty/primitives.rs 69.56% <0.00%> (+4.34%) ⬆️
crates/mun_hir/src/arena.rs 77.14% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72b965...52c31f1. Read the comment docs.

@baszalmstra baszalmstra merged commit 93ad9b8 into mun-lang:master Mar 25, 2020
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
@Wodann Wodann deleted the test/incremental-compilation branch May 14, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants