freeroam: Fix warning when time is set to freeze #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LosFaul
changed the title
qaisjp
approved these changes
Jul 18, 2020
qaisjp
reviewed
Jul 18, 2020
Comment on lines
+1880
to
1882
| freezeTimeHour, freezeTimeMinute = getTime() | ||
| freezeTimeWeather = getWeather() | ||
| setTimeFrozen(state) |
There was a problem hiding this comment.
Isn't the fix just to do setTimeFrozen(state, freezeTimeHour, freezeTimeMinute, freezeTimeWeather) and there's no need for a global? Or does this also support changing time/weather while frozen (and it will freeze to the new time/weather).
There was a problem hiding this comment.
someone was complaining that it would change time/weather back few seconds later to the state freeze was enbaled
so, i added the 3 variables to keep the state updated when time and weather get changed while freeze is enabled
qaisjp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warning when time is set to freeze in fr_client.lua