Add information about standard encoding.#26
Open
btrask wants to merge 1 commit intomultiformats:masterfrom
Open
Add information about standard encoding.#26btrask wants to merge 1 commit intomultiformats:masterfrom
btrask wants to merge 1 commit intomultiformats:masterfrom
Conversation
| sha1 4 bytes 4 byte sha1 digest | ||
| ``` | ||
|
|
||
| The standard encoding is base-58, using the [Bitcoin character set](https://en.bitcoin.it/wiki/Base58Check_encoding#Base58_symbol_chart). |
Member
There was a problem hiding this comment.
This is not part of multihash per-se, and weill be rolled out into multibase.
the fact that IPFS uses a naked (non multibase) base58 encoded multihash is a separate story.
There was a problem hiding this comment.
I agree. To be explicit, we can add some text like:
The multihash spec does not require any specific type of encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses my only criticism with the MultiHash standard.