feat: add proquint #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're removing proquint support from IPNS and making it a multibase. I've chosen `p` or "pro-" so proquints are always fully pronounceable.
2 tasks
ribasushi
reviewed
Apr 21, 2021
Co-authored-by: Peter Rabbitson <ribasushi@protocol.ai>
lidel
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Merging this as draft (to reserve p) and seeing if anyone asks us to implement it sounds like a good plan.
ps. indedd, pro- is way better for "pronouncable" identifiers than... 0q-
(sic! – thats the "magic numbers" prefix suggested in the original paper 🙃 )
Also, that starts with |
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're removing proquint support from IPNS and making it a multibase. I've chosen
por "pro-" so proquints are always fully pronounceable.