From c7104b71e930c3d0e04dd558a95f2ae110b62433 Mon Sep 17 00:00:00 2001 From: Alex Potsides Date: Tue, 14 Mar 2023 20:52:24 +0100 Subject: [PATCH] fix: Rename webrtc-w3c to webrtc and webrtc to webrtc+sdp-munging Following on from https://github.com/multiformats/multiaddr/pull/150 and an replacement for https://github.com/multiformats/multiaddr/pull/151 Renames: - `/webrtc-w3c` -> `/webrtc` - AKA browser to browser - `/webrtc` -> `/webrtc+sdp-munging` - AKA browser to server Discussion: - This option comes from comments on https://github.com/multiformats/multiaddr/pull/151 - It got a lukewarm reception on the triage call so it's presented as an option along with https://github.com/multiformats/multiaddr/pull/152 - Adding `+sdp-munging` makes it more explicit about the differences, though admittedly there are other differences that aren't encapsulated in the name - People were uncertain about universal understanding of the term "SDP munging" --- protocols.csv | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/protocols.csv b/protocols.csv index 23a1522..8d1d32e 100644 --- a/protocols.csv +++ b/protocols.csv @@ -35,7 +35,7 @@ code, size, name, comment 277, 0, p2p-stardust, 275, 0, p2p-webrtc-star, 276, 0, p2p-webrtc-direct, -280, 0, webrtc, ICE-lite webrtc transport -281, 0, webrtc-w3c, webrtc transport where connection establishment is according to w3c spec +280, 0, webrtc+sdp-munging, ICE-lite webrtc transport with SDP munging during connection establishment and without use of a STUN server +281, 0, webrtc, webrtc transport where connection establishment is according to w3c spec 290, 0, p2p-circuit, 777, V, memory, in memory transport for self-dialing and testing; arbitrary