Skip to content

Commit e8c3d7d

Browse files
committed
fix: change UDP code
BREAKING CHANGE: The UDP code was changed in the multicodec table The UDP code is now `273` instead of `17`. For the full discussion of this change please see multiformats/multicodec#16. Fixes #17.
1 parent 60251ad commit e8c3d7d

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ $ node
107107
> addr.protos()
108108
[
109109
{code: 4, name: 'ip4', size: 32},
110-
{code: 17, name: 'udp', size: 16}
110+
{code: 273, name: 'udp', size: 16}
111111
]
112112

113113
// gives you an object that is friendly with what Node.js core modules expect for addresses

src/convert.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Convert.toString = function convertToString (proto, buf) {
2525
return ip.toString(buf)
2626

2727
case 6: // tcp
28-
case 17: // udp
28+
case 273: // udp
2929
case 33: // dccp
3030
case 132: // sctp
3131
return buf2port(buf)
@@ -51,7 +51,7 @@ Convert.toBuffer = function convertToBuffer (proto, str) {
5151
return ip2buf(new ipAddress.Address6(str))
5252

5353
case 6: // tcp
54-
case 17: // udp
54+
case 273: // udp
5555
case 33: // dccp
5656
case 132: // sctp
5757
return port2buf(parseInt(str, 10))

src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ Multiaddr.prototype.isThinWaistAddress = function isThinWaistAddress (addr) {
372372
if (protos[0].code !== 4 && protos[0].code !== 41) {
373373
return false
374374
}
375-
if (protos[1].code !== 6 && protos[1].code !== 17) {
375+
if (protos[1].code !== 6 && protos[1].code !== 273) {
376376
return false
377377
}
378378
return true

src/protocols-table.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Protocols.V = V
2727
Protocols.table = [
2828
[4, 32, 'ip4'],
2929
[6, 16, 'tcp'],
30-
[17, 16, 'udp'],
30+
[273, 16, 'udp'],
3131
[33, 16, 'dccp'],
3232
[41, 128, 'ip6'],
3333
[54, V, 'dns4', 'resolvable'],

test/index.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,15 @@ describe('requiring varint', () => {
9898
describe('manipulation', () => {
9999
it('basic', () => {
100100
const udpAddrStr = '/ip4/127.0.0.1/udp/1234'
101-
const udpAddrBuf = Buffer.from('047f0000011104d2', 'hex')
101+
const udpAddrBuf = Buffer.from('047f000001910204d2', 'hex')
102102
const udpAddr = multiaddr(udpAddrStr)
103103

104104
expect(udpAddr.toString()).to.equal(udpAddrStr)
105105
expect(udpAddr.buffer).to.deep.equal(udpAddrBuf)
106106

107-
expect(udpAddr.protoCodes()).to.deep.equal([4, 17])
107+
expect(udpAddr.protoCodes()).to.deep.equal([4, 273])
108108
expect(udpAddr.protoNames()).to.deep.equal(['ip4', 'udp'])
109-
expect(udpAddr.protos()).to.deep.equal([multiaddr.protocols.codes[4], multiaddr.protocols.codes[17]])
109+
expect(udpAddr.protos()).to.deep.equal([multiaddr.protocols.codes[4], multiaddr.protocols.codes[273]])
110110
expect(udpAddr.protos()[0] === multiaddr.protocols.codes[4]).to.equal(false)
111111

112112
const udpAddrBuf2 = udpAddr.encapsulate('/udp/5678')

0 commit comments

Comments
 (0)