Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] CSV export incorrect if cell data contains comma #1143

Closed
2 tasks done
zj9495 opened this issue Mar 2, 2021 · 1 comment · Fixed by #1154
Closed
2 tasks done

[DataGrid] CSV export incorrect if cell data contains comma #1143

zj9495 opened this issue Mar 2, 2021 · 1 comment · Fixed by #1154
Assignees
@DanailH
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!

Comments

@zj9495
Copy link
Contributor

zj9495 commented Mar 2, 2021

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

image
image

Expected Behavior 🤔

image

Steps to Reproduce 🕹

Steps:

1.open https://codesandbox.io/s/material-demo-forked-zdvow?file=/demo.tsx
2.click Export -> Download as CSV
@zj9495 zj9495 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 2, 2021
@DanailH
Copy link
Member

DanailH commented Mar 2, 2021

Hey @zj9495 thanks for catching this, I'll take a look.

@DanailH DanailH self-assigned this Mar 2, 2021
@DanailH DanailH added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 2, 2021
@DanailH DanailH changed the title [GridToolBar] When there is a comma in the table, the exported csv file is incorrect [DataGrid] CSV export incorrect if cell data contains comma Mar 2, 2021
@DanailH DanailH mentioned this issue Mar 3, 2021
Merged
@stevieg2123 stevieg2123 mentioned this issue Mar 4, 2021
Closed
2 tasks
@z0d14c z0d14c mentioned this issue Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanailH DanailH

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Handle special chars when doing CSV export DanailH/material-ui-x
2 participants
@DanailH @zj9495