Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Stop re-exporting locales from package root #10919

Closed
Tracked by #7902
LukasTy opened this issue Nov 6, 2023 · 1 comment · Fixed by #11614
Closed
Tracked by #7902

[l10n] Stop re-exporting locales from package root #10919

LukasTy opened this issue Nov 6, 2023 · 1 comment · Fixed by #11614
Assignees
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes l10n localization performance v7.x

Comments

@LukasTy
Copy link
Member

LukasTy commented Nov 6, 2023

We currently re-export locales from in the root index file so that they are available from both import { frFR } from '@mui/x-data-grid' and import { frFR } from '@mui/x-data-grid/locales'.

export * from './locales';

We should avoid root-level exporting as it doesn't solve any particular problem besides making the package seem bulkier.

Related to mui/material-ui#39525

Search keywords:

@LukasTy LukasTy added core Infrastructure work going on behind the scenes breaking change component: data grid This is the name of the generic UI component, not the React module! l10n localization v7.x labels Nov 6, 2023
@cherniavskii cherniavskii self-assigned this Dec 18, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 4, 2024

making the package seem bulkier

Very much agree, it doesn't help market https://bundlephobia.com/package/@mui/x-data-grid@6.18.6

Screenshot 2024-01-04 at 17 42 48

the reality is more:


It also slows the load time when not using deep imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes l10n localization performance v7.x
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants