-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
[code-infra] Type checking: use --incremental
#47204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewhttps://deploy-preview-47204--material-ui.netlify.app/ Bundle size report
|
.circleci/config.yml
Outdated
| - save_cache: | ||
| key: typescript-cache-v3-{{ checksum "pnpm-lock.yaml" }} | ||
| paths: | ||
| - docs/scripts/tsconfig.tsbuildinfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this support globs? It'll be better for future proofing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, doesn't support globs unfortunately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll experiment a bit with a CLI that can take a glob, and that can move/copy the result into a single folder, with a manifest. Then a second CLI that can take this folder and based on the manifest puts everything back in place.
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Speed up type checking by leverage
--incrementalcompilation and caching tsbuildinfowithout cache: 8m39s
with cache: 5m32s (-36%)