-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][material-ui] Bring back *Component
and *Props
codemods and deprecation messages
#44383
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewBundle size report |
*Component
and *Props
deprecation messages*Component
and *Props
codemods and deprecation messages
There are few PR's which were closed due to unsure of direction, do you think they can be reopened? |
Yep, we can re-open them if the contributor are still interested in continuing the effort. |
@@ -87,6 +87,36 @@ You can also manually update your theme as shown in the snippet below: | |||
|
|||
This reduces the API surface and lets you define variants in other slots of the component. | |||
|
|||
## Accordion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page could become confusing. If we plan to continue to add these sections here, we should include the version in which the new API was introduced. Otherwise people may run the codemod while installing an older version (e.g. 6.0.0).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into how to do this
In #42466, we reverted these codemods and deprecation messages as we weren't sure of the direction of the slot pattern. Now that we're continuing this effort, we're bringing the deprecation messages back.
This PR also modifies
Autocomplete
'sListboxComponent
deprecation and codemods to point toslotProps.listbox.component
instead ofslots.listbox
, which is the correct migration path.