Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Bring back *Component and *Props codemods and deprecation messages #44383

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Nov 11, 2024

In #42466, we reverted these codemods and deprecation messages as we weren't sure of the direction of the slot pattern. Now that we're continuing this effort, we're bringing the deprecation messages back.

This PR also modifies Autocomplete's ListboxComponent deprecation and codemods to point to slotProps.listbox.component instead of slots.listbox, which is the correct migration path.

@DiegoAndai DiegoAndai added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Nov 11, 2024
@DiegoAndai DiegoAndai self-assigned this Nov 11, 2024
@mui-bot
Copy link

mui-bot commented Nov 11, 2024

@DiegoAndai DiegoAndai changed the title [docs][material-ui] Bring back *Component and *Props deprecation messages [docs][material-ui] Bring back *Component and *Props codemods and deprecation messages Nov 11, 2024
@sai6855
Copy link
Contributor

sai6855 commented Nov 12, 2024

Now that we're continuing this effort, we're bringing the deprecation messages back.

There are few PR's which were closed due to unsure of direction, do you think they can be reopened?

@mnajdova
Copy link
Member

There are few PR's which were closed due to unsure of direction, do you think they can be reopened?

Yep, we can re-open them if the contributor are still interested in continuing the effort.

@@ -87,6 +87,36 @@ You can also manually update your theme as shown in the snippet below:

This reduces the API surface and lets you define variants in other slots of the component.

## Accordion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page could become confusing. If we plan to continue to add these sections here, we should include the version in which the new API was introduced. Otherwise people may run the codemod while installing an older version (e.g. 6.0.0).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into how to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants