[input] Fix layout shift with display: flex #43839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43839--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
oliviertassinari
force-pushed
the
branch-test
branch
from
b88a7b2 to
ce34ac8
Compare
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
branch-test
branch
from
ce34ac8 to
9257196
Compare
siriwatknp
reviewed
Dec 4, 2024
Comment on lines
+260
to
+261
| '@keyframes mui-auto-fill': {}, | ||
| '@keyframes mui-auto-fill-cancel': {}, |
There was a problem hiding this comment.
Why not removing the InputGlobalStyles entirely?
There was a problem hiding this comment.
Per the history of those lines, it was required for the autofill detection logic to work. But, ok, I didn't test if it's still true.
There was a problem hiding this comment.
If this trick involving the dummy animation to expose a JS hook still works, it may be needed to fix #44135 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #39539. A regression introduced in Chrome #26449 (comment) after #28070.
As an end-user, I was annoyed by #39539 (comment), the template doesn't feel great with a bug like this. It makes us look like amateurs.
You can test that is works on https://deploy-preview-43839--material-ui.netlify.app/experiments/base/autofill/.
Screen.Recording.2024-09-22.at.01.44.40.mov
and https://deploy-preview-43839--material-ui.netlify.app/material-ui/getting-started/templates/dashboard/.
TODO
Regarding [InputBase] Fix autofill issue #28070 I'm not sure what happened but emotion doesn't removed empty keyframe with the version that we have today:
@emotion/styled@11.13.0
@emotion/react@11.13.3
The reproduction in #26449 uses:
To dive deeper, don't want to merge without clarity on this.