[system][InitColorSchemeScript] Use let/const instead of var#43468
Merged
Conversation
zannager
added
the
scope: system
1 task
siriwatknp
reviewed
Aug 28, 2024
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
siriwatknp
approved these changes
Aug 28, 2024
Member
siriwatknp
left a comment
siriwatknp
left a comment
There was a problem hiding this comment.
👍 Thanks for your contribution!
Netlify deploy previewhttps://deploy-preview-43468--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Contributor
Author
My pleasure! Thanks for the review @siriwatknp :) |
oliviertassinari
added
the
internal
…ial-ui into 43418-use-let-instead-of-var
This was referenced Sep 25, 2024
This was referenced Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
varusage with the ES6 recommendedlet/constin the code snippet.Fixes #43418