Skip to content

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Aug 15, 2024

It looks like these were forgotten in #42920? This would allow us to add package "exports" on a minor.

@Janpot Janpot added internal Behind-the-scenes enhancement. Formerly called “core”. docs Improvements or additions to the documentation. breaking change Introduces changes that are not backward compatible. dependencies Update of dependencies. v6.x migration and removed internal Behind-the-scenes enhancement. Formerly called “core”. labels Aug 15, 2024
@Janpot Janpot changed the title [core] Update node to 14 [core] Update supported Node.js version to 14 Aug 15, 2024
@aarongarciah
Copy link
Member

aarongarciah commented Aug 15, 2024

Nice catch. Maybe we can update @mui/utils too?

edit: nevermind, you already pushed a commit addressing it 🦸‍♂️

@mui-bot
Copy link

mui-bot commented Aug 15, 2024

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jan!

@Janpot
Copy link
Member Author

Janpot commented Aug 15, 2024

@aarongarciah Making a few changes to fix the errors introduced in #43290 and prevent them in the future.

cc @JCQuintas this is why I push back against running ci conditionally. So easy to break, especially when it's manually maintained.

edit: removing the fix again, it's handled by #43316

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 15, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 15, 2024
@Janpot Janpot marked this pull request as ready for review August 15, 2024 16:39
@Janpot Janpot enabled auto-merge (squash) August 15, 2024 16:48
@Janpot Janpot merged commit eebde2e into mui:next Aug 15, 2024
@Janpot Janpot deleted the node-14 branch August 15, 2024 16:59
@JCQuintas
Copy link
Member

@aarongarciah Making a few changes to fix the errors introduced in #43290 and prevent them in the future.

cc @JCQuintas this is why I push back against running ci conditionally. So easy to break, especially when it's manually maintained.

edit: removing the fix again, it's handled by #43316

I don't see where the issue was with the CI itself? I guess it was a typescript issue?

I don't think it is inherently bad. If we always run all the CI we can get cost issues or time issues. If we optimise for running only in very specific scenarios we run the chance of making them brittle.

Each case is a different case. So we should always take them into account when making decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. dependencies Update of dependencies. docs Improvements or additions to the documentation. v6.x migration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants