update dropdown menu spacing to reflect material spec #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why it was set to that height to begin with. Thanks @salarkhan |
hai-cea
added a commit
that referenced
this pull request
Jul 12, 2015
update dropdown menu spacing to reflect material spec
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* [docs] Fix crashing on changing utils * Rewrite MuiPickersUtilsProvider on hooks * Fix moment localization example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Height of the entire component should be 48, instead of 56. I only noticed when I saw a SelectField and a DropDownMenu side by side and noticed that their spacing was different.
If I'm being dumb and totally missing the mark here, lemme know! :)