Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC][material-ui] Should variant class names have the variant prefix? #41277

Open
DiegoAndai opened this issue Feb 26, 2024 · 1 comment
Open

[RFC][material-ui] Should variant class names have the variant prefix? #41277

DiegoAndai opened this issue Feb 26, 2024 · 1 comment
Labels
customization: css Design CSS customizability package: material-ui Specific to @mui/material RFC Request For Comments
Milestone
Material UI v8 (d...

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Feb 26, 2024 •
edited by ZeeshanTamboli
Loading

Extracted issue from #40688 (comment)

What's the problem?

Currently, the variants' class names don't have a prefix, for example, MuiButton-outlined. This differs from other prop values classes with the prop name prefixed, for example, MuiButton-colorPrimary.

Should we change this for consistency? Is it worth it?

What are the requirements?

  • The accepted proposal should have an answer on whether the consistency and predictability of the API are enough of an argument to go through this change.

What are our options?

  • Add the variant prefix
  • Keep with the variant prefix

Proposed solution

No response

Search keywords:
@DiegoAndai DiegoAndai added status: waiting for maintainer These issues haven't been looked at yet by a maintainer RFC Request For Comments labels Feb 26, 2024
@DiegoAndai DiegoAndai added this to the Material UI: v7 (draft) milestone Feb 26, 2024
@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label Feb 26, 2024
@DiegoAndai DiegoAndai mentioned this issue Feb 27, 2024
Merged
@DiegoAndai DiegoAndai added customization: css Design CSS customizability and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 27, 2024
@samuelsycamore samuelsycamore removed their assignment Feb 27, 2024
@ZeeshanTamboli
Copy link
Member

My opinion is #40688 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customization: css Design CSS customizability package: material-ui Specific to @mui/material RFC Request For Comments
Projects
None yet
Milestone
Material UI v8 (draft)
Development

No branches or pull requests
5 participants
@oliviertassinari @DiegoAndai @ZeeshanTamboli @danilo-leal @samuelsycamore