Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwipeableDrawer: transition equal to 0 hangs application #37253

Open
2 tasks done
iliubinskii opened this issue May 12, 2023 · 4 comments
Open
2 tasks done

SwipeableDrawer: transition equal to 0 hangs application #37253

iliubinskii opened this issue May 12, 2023 · 4 comments
Assignees
Labels
breaking change component: drawer This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component.

Comments

@iliubinskii
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example:
Not working right

Steps:

  1. Click button
  2. Close drawer
  3. Try to click button again

Current behavior 😯

At step 3 button is not clickable. App is "hanging"

Expected behavior 🤔

At step 3 button should be clickable

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@iliubinskii iliubinskii added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 12, 2023
@DIWAKARKASHYAP
Copy link
Contributor

DIWAKARKASHYAP commented May 14, 2023

Hi , @ilyub
i check your example and also check the official doc of MUI . then i find that you miss an argument inside the object in line number 43 in your code that is " exit: 0 "

image

after write this argument , your code working properly
and you have another option , in line no 43 you can replace the whole object by the time in millisecond

@iliubinskii
Copy link
Author

check your example and also check the official doc of MUI . then i find that you miss an argument inside the object in line number 43 in your code that is " exit: 0 "

In fact I didn't miss "exit" argument. I wanted to remove entering transition, while leaving default duration for exit transition.

To me, the most logical behavior is to use default for missing arguments. I think this should be very easy to do.

If you can't fix component hanging with missing exit, then you might make it required.

In any case, current situation when you let me skip "exit" and it hangs component is buggy.

@DIWAKARKASHYAP
Copy link
Contributor

got it . i try to fix this

@zannager zannager added component: drawer This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component. labels May 15, 2023
@mnajdova
Copy link
Member

As a workaround you can use exit theme.transitions.duration.leavingScreen. I feel like changing the logic at this moment could be considered a breaking change. In v6 we can consider using the best defaults if they are not specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: drawer This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component.
Projects
Status: Backlog
Development

No branches or pull requests

6 participants