Skip to content

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Oct 29, 2025

Ensures focus isn't lost from the input when pressing the list element with the pointer, in case it has the padding instead of the popup (as with changes in #3091)

@atomiks atomiks added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. component: autocomplete Changes related to the autocomplete component. component: combobox Changes related to the combobox component. labels Oct 29, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 29, 2025

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@3092
pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@3092

commit: fc3ed63

@mui-bot
Copy link

mui-bot commented Oct 29, 2025

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 🔺+17B(0.00%) 🔺+8B(+0.01%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit fc3ed63
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69038ecbb4a79300084274fb
😎 Deploy Preview https://deploy-preview-3092--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. 👍
I've adjusted tests, feel free to change it though, but seems to make sense.

Also tested on Spectrum, it keeps the focus on input when clicking on scrollbar - the state of this PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: autocomplete Changes related to the autocomplete component. component: combobox Changes related to the combobox component. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants