[Select] Retain the highlight state when closing

[vladmoroz]

This is mostly a nit/polish item.
When closing the select, there's a frame of slight flicker/unnecessary motion:

Screen.Recording.2024-12-05.at.13.27.44.mov

Frame by frame:

1. Right after clicking an option: there's a highlight on the clicked option (possibly retained from the hover). The previous value still has the indicator.

2. Next frame: the check icon is moved to its new place, but the highlight is lost

3. The popup is closed

Ideally:

• If animated, I think we need to make sure that from frame (2), the highlight is set and persisted until mouse movement and/or popup is fully closed. When animating the popup, it should be animating with the newly highlighted item visible.
• If not animated, the Select should close immediately without frame (2)

Search keywords:

[atomiks]

If not animated, the Select should close immediately without frame (2)

@michaldudak now I remember that's what the flushSync was for in Select - it skips that frame. Removing it causes the 1 frame flash.

Retaining the highlight would fix that though even if the frame is kept.

I suppose this currently removes it?

.Option[data-selected]:not([data-open]),
.Option[data-highlighted] {
  /* highlighted state */
}

[github-actions]

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.