Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modal] Escape shouldn't trigger until IME is settled #699

Open
oliviertassinari opened this issue Oct 1, 2024 · 4 comments
Open

[modal] Escape shouldn't trigger until IME is settled #699

oliviertassinari opened this issue Oct 1, 2024 · 4 comments
Labels
bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module! priority: low To delay as much as possible regression A bug, but worse

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 1, 2024

Steps to reproduce

Steps:

  1. Open https://master--base-ui.netlify.app/components/react-dialog/
  2. Start typing into the input. Start a composite word. Press Escape to cancel it.

Current behavior

It closes the modal

Japanese:

Screen.Recording.2024-10-02.at.00.26.33.mov

French:

Screen.Recording.2024-10-02.at.00.26.13.mov

Expected behavior

It only closes the composite selector. https://mui.com/base-ui/react-modal/#component

Screen.Recording.2024-10-02.at.00.31.32.mov

Context

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer bug 🐛 Something doesn't work regression A bug, but worse component: modal This is the name of the generic UI component, not the React module! priority: low To delay as much as possible labels Oct 1, 2024
@naaa760

This comment was marked as outdated.

@naaa760

This comment was marked as outdated.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 2, 2024

@naaa760 This is low priority, we have no plan to fix it in the short term.

@atomiks
Copy link
Contributor

atomiks commented Oct 9, 2024

If event.isComposing is unreliable in Safari then Number Field also needs to change to the event.which technique.

@oliviertassinari oliviertassinari removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module! priority: low To delay as much as possible regression A bug, but worse
Projects
None yet
Development

No branches or pull requests

4 participants