Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dialog] Popup doesn't forward the style prop #620

Closed
vladmoroz opened this issue Sep 16, 2024 · 1 comment · Fixed by #641
Closed

[dialog] Popup doesn't forward the style prop #620

vladmoroz opened this issue Sep 16, 2024 · 1 comment · Fixed by #641
Assignees
@michaldudak
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module!

Comments

@vladmoroz
Copy link
Contributor

vladmoroz commented Sep 16, 2024 •
edited by github-actions bot
Loading

Steps to reproduce

Link to live example:
https://codesandbox.io/p/sandbox/still-resonance-forked-vc3vjv?file=%2Fsrc%2FApp.tsx%3A13%2C21

Current behavior

No response

Expected behavior

No response

Context

Haven't tested this with all the parts/component exhaustively, just ran into this one randomly.

Your environment

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: dialog popup style prop
@vladmoroz vladmoroz added status: waiting for maintainer These issues haven't been looked at yet by a maintainer component: dialog This is the name of the generic UI component, not the React module! labels Sep 16, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Base UI Sep 16, 2024
@michaldudak michaldudak mentioned this issue Sep 23, 2024
Merged
@michaldudak michaldudak added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 23, 2024
@michaldudak michaldudak moved this from Backlog to In progress in Base UI Sep 24, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Base UI Sep 24, 2024
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaldudak michaldudak

Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module!
Projects
Base UI
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dialog][Collapsible] Fix style prop merging michaldudak/base-ui
2 participants
@michaldudak @vladmoroz