-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tooltip] Tooltip touch the edge #413
Labels
bug 🐛
Something doesn't work
component: tooltip
This is the name of the generic UI component, not the React module!
design
This is about UI or UX design, please involve a designer
Comments
oliviertassinari
added
bug 🐛
Something doesn't work
component: tooltip
This is the name of the generic UI component, not the React module!
design
This is about UI or UX design, please involve a designer
package: joy-ui
labels
Jun 17, 2023
@oliviertassinari animation/transition is tracked here mui/material-ui#36695. |
@oliviertassinari I would like to pick this up |
This comment was marked as resolved.
This comment was marked as resolved.
I think we depends on a fix in Base UI: #39. |
oliviertassinari
changed the title
[Tooltip] Joy UI tooltip touch the edge
[Tooltip] Tooltip touch the edge
Oct 19, 2023
oliviertassinari
changed the title
[Tooltip] Tooltip touch the edge
[tooltip] Tooltip touch the edge
Aug 30, 2024
This is no longer an issue with the new Tooltip component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: tooltip
This is the name of the generic UI component, not the React module!
design
This is about UI or UX design, please involve a designer
Steps to reproduce 🕹
Link to live example:
Steps:
Current behavior 😯
Expected behavior 🤔
Context
Material UI handles this a bit better:
https://github.com/mui/material-ui/blob/e64928daf64fcce9702e2659e44ecb348aa97403/packages/mui-material/src/Tooltip/Tooltip.js#L130
though we might want 4px, it feels much better than 2px. But note that the implementation of it in Material UI is broken, the 2px is also included for the start positioning placement 🙈. We need to fix this too.
The Popover component has a
marginThreshold
prop for this very use case.Benchmark
Radix Primitive solves this with a custom
collisionPadding
prop on the Popper.Off-topic
I really feel the lack of animation on the tooltip in Joy UI, I wouldn't use this component as is in a side-project. I think it's x10 more important to fix the transition than this issue that I opened here 😁.
Your environment 🌎
@mui/joy
v5.0.0-alpha.84cc @siriwatknp
Search keywords:
The text was updated successfully, but these errors were encountered: