Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tooltip] Tooltip touch the edge #413

Closed
oliviertassinari opened this issue Jun 17, 2023 · 6 comments
Closed

[tooltip] Tooltip touch the edge #413

oliviertassinari opened this issue Jun 17, 2023 · 6 comments
Labels
bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 17, 2023

Steps to reproduce 🕹

Link to live example:

Steps:

  1. https://codesandbox.io/s/cranky-napier-rghkwn
  2. This feels off. I first saw this in [Tooltip] Long press select text on iOS material-ui#23232 (comment)

Current behavior 😯

Screenshot 2023-06-17 at 19 40 02

Expected behavior 🤔

Screenshot 2023-06-17 at 19 38 19

Context

Benchmark

Off-topic

I really feel the lack of animation on the tooltip in Joy UI, I wouldn't use this component as is in a side-project. I think it's x10 more important to fix the transition than this issue that I opened here 😁.

Your environment 🌎

@mui/joy v5.0.0-alpha.84

cc @siriwatknp

Search keywords:

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: joy-ui labels Jun 17, 2023
@siriwatknp
Copy link
Member

siriwatknp commented Jun 19, 2023

Off-topic, I really feel the lack of animation on the tooltip, it feels rusty without it. I think it's much most important to fix than this issue that I opened here 😁.

@oliviertassinari animation/transition is tracked here mui/material-ui#36695.

@gitstart
Copy link

@oliviertassinari I would like to pick this up

@oliviertassinari

This comment was marked as resolved.

@oliviertassinari
Copy link
Member Author

I think we depends on a fix in Base UI: #39.

@oliviertassinari oliviertassinari changed the title [Tooltip] Joy UI tooltip touch the edge [Tooltip] Tooltip touch the edge Oct 19, 2023
@oliviertassinari oliviertassinari transferred this issue from mui/material-ui May 24, 2024
@oliviertassinari oliviertassinari changed the title [Tooltip] Tooltip touch the edge [tooltip] Tooltip touch the edge Aug 30, 2024
@michaldudak
Copy link
Member

This is no longer an issue with the new Tooltip component.

@oliviertassinari
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer
Projects
None yet
Development

No branches or pull requests

4 participants