Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Progress] Styling feedback #1201

Open
vladmoroz opened this issue Dec 20, 2024 · 1 comment
Open

[Progress] Styling feedback #1201

vladmoroz opened this issue Dec 20, 2024 · 1 comment
Labels
breaking change component: progress This is the name of the generic UI component, not the React module!

Comments

@vladmoroz
Copy link
Contributor

vladmoroz commented Dec 20, 2024

  • In this current format, the Track part seems unnecessary for styling and fully duplicates Root
  • data-progressing gives weird vibes. data-in-progress would be easier to remember as a more natural phrase
  • When the value is at 0, the indicator doesn't have width: 0%. When using a transition on the width, this breaks the transition from 0.
  • Having aria-label, aria-labelledby, aria-valuetext, getAriaLabel, getAriaValueText exposed as labelling props strikes me as a very different API style from most of the other components, which usually have separate parts for labelling. Perhaps worth reconsidering how to approach this.
@vladmoroz vladmoroz added breaking change component: progress This is the name of the generic UI component, not the React module! labels Dec 20, 2024
@mj12albert
Copy link
Member

When the value is at 0, the indicator doesn't have width: 0%. When using a transition on the width, this breaks the transition from 0

This one is just a bug 😐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: progress This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

2 participants