Allowed multiple records for the Model method delete

Author: muflone

pyodoo/v12/api.py

@@ -238,14 +238,14 @@ def do_update(self,
         return results
 
     def do_delete(self,
-                  entity_id: int,
+                  entity_id: Union[int, list[int]],
                   options: dict[str, Any]) -> bool:
         """
-        Delete a record in the requested model
+        Delete one or multiple records in the requested model
 
-        :param entity_id: Object ID to delete
+        :param entity_id: The Object IDs to delete
         :param options: Dictionary with options to use
-        :return: True if the record was deleted
+        :return: True if the records were deleted
         """
         results = self.do_execute(method_name='unlink',
                                   args=[entity_id],

pyodoo/v12/model.py

@@ -362,14 +362,14 @@ def update(self,
         return results
 
     def delete(self,
-               entity_id: int,
+               entity_id: Union[int, list[int]],
                options: dict[str, Any] = None) -> bool:
         """
-        Delete a row from a model using its ID
+        Delete one or multiple rows from a model using the object IDs
 
-        :param entity_id: The object ID to delete
+        :param entity_id: The object IDs to delete
         :param options: Dictionary with options to use
-        :return: True if the record was deleted
+        :return: True if the records were deleted
         """
         if options is None:
             options = {}

tests/test_contacts.py

@@ -633,7 +633,8 @@ def test_32_delete(self) -> None:
         self.assertIsNotNone(contacts)
         self.assertGreater(len(contacts), 0)
         # Delete found data
-        for entity_id in contacts:
+        if contacts:
+            entity_id = contacts[0]
             try:
                 results = self.model.delete(entity_id=entity_id)
                 self.assertTrue(results)
@@ -650,7 +651,33 @@ def test_32_delete(self) -> None:
                     # We catched a different error, re-raise it
                     raise error
 
-    def test_33_language(self) -> None:
+    def test_33_delete_many(self) -> None:
+        """
+        Delete the newly created rows.
+        This test may be skipped in the case there's an active PoS session
+        as Odoo doesn't allow contacts deletion when there's some active
+        PoS session
+        """
+        filters = [Filter(field='name',
+                          compare_type=CompareType.CONTAINS,
+                          value=f'{APP_NAME} v.{APP_VERSION}')]
+        contacts = self.model.search(filters=filters)
+        # Check if we have results
+        self.assertIsNotNone(contacts)
+        # Delete found data
+        try:
+            results = self.model.delete(entity_id=contacts)
+            self.assertTrue(results)
+        except xmlrpc.client.Fault as error:
+            if error.faultCode == 2:
+                # We have an active PoS session running
+                # It's not possible to delete contacts until it's closed
+                pass
+            else:
+                # We catched a different error, re-raise it
+                raise error
+
+    def test_34_language(self) -> None:
         """
         Get the current default language, change and restore it
         """
@@ -667,15 +694,15 @@ def test_33_language(self) -> None:
         results = self.model.language
         self.assertEqual(results, original_language)
 
-    def test_34_get_fields(self) -> None:
+    def test_35_get_fields(self) -> None:
         """
         Get the model fields
         """
         results = self.model.get_fields()
         # Check if we have results
         self.assertIsNotNone(results)
 
-    def test_35_get_fields_attributes(self) -> None:
+    def test_36_get_fields_attributes(self) -> None:
         """
         Get the model fields
         """
@@ -688,7 +715,7 @@ def test_35_get_fields_attributes(self) -> None:
         self.assertIn('string', field_name)
         self.assertIn('type', field_name)
 
-    def test_36_get_model(self) -> None:
+    def test_37_get_model(self) -> None:
         """
         Get a new Model object
         """