Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new bee for JIRA integration #366

Merged
merged 9 commits into from
Jan 18, 2021
Merged

Conversation

corrantho
Copy link
Contributor

As requested in #10, here is a first version of a new bee for JIRA integration. For the moment it has only one action create_issue but transition_issue is coming soon.

Since I'm new to Golang and on this project, I would like to have already a code review on this small increment to be sure I'm in line with your development guidelines.

Also, regarding the triggering events, I was thinking about exposing an HTTP endpoint in order to receive JIRA events in real-time via a Webhook. Do you have any constraint with this? I've not seen any other bee using this mechanism (except the WebBee).

Another question regarding the logo. Where do you get them? Should it be an opensource logo?

Thanks in advance.

JiraBee - Added create_issue action
JiraBee - Added update_issue_status action
@muesli
Copy link
Owner

muesli commented Jan 2, 2021

Nice, good start for a new bee. One thing is still missing tho: an icon.

Eventually, it would be great to also provide a couple of events, of course 😊

JiraBee - Added comment_issue action
@corrantho
Copy link
Contributor Author

@muesli thanks for the code review.

I'm going to add some events that's why I kept the Events method 😄
Regarding the logo/icon, should it be opensource or can I just copy the one from the JIRA website?

@muesli
Copy link
Owner

muesli commented Jan 5, 2021

I consider logo usage a grey area. So far we haven't had issues with that, so I'd say let's use the Jira logo. People should be able to recognize it - which is the entire point of having an "icon" 😃

JiraBee - Added logo and changed hive color
…o.mod

JiraBee - Added support of issue_created event + updated go.sum and go.mod
@corrantho
Copy link
Contributor Author

I will add one more event to handle issue status updates and I think I will be done with this bee.

JiraBee - Added support of issue_status_updated event
@corrantho
Copy link
Contributor Author

@muesli I think it's ready for the final review 😃
Could you also suggest where to put the documentation?

bees/jirabee/events.go Outdated Show resolved Hide resolved
- handleIssueCreatedEvent raises an error when Issue is empty
- handleJiraEvent handles errors
@muesli
Copy link
Owner

muesli commented Jan 18, 2021

LGTM, thank you for your contribution!

@muesli muesli merged commit 7e793ce into muesli:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants