Remove unsafe strncpy and use safer snprintf. (#20)

rogersm · xenith · commit a3e7c68fb179 · 2018-02-07T12:07:56.000-08:00
diff --git a/src/action_safe.c b/src/action_safe.c
@@ -156,7 +156,7 @@ void cmd_copyover(D_MOBILE *dMob, char *arg)
     return;
   }
 
-  strncpy(buf, "\n\r <*>            The world starts spinning             <*>\n\r", MAX_BUFFER);
+  snprintf(buf, sizeof(buf), "%s", "\n\r <*>            The world starts spinning             <*>\n\r");
 
   /* For each playing descriptor, save its state */
   AttachIterator(&Iter, dsock_list);

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ void cmd_copyover(D_MOBILE dMob, char arg)`
`156`	`156`	`return;`
`157`	`157`	`}`
`158`	`158`
`159`		`- strncpy(buf, "\n\r <> The world starts spinning <>\n\r", MAX_BUFFER);`
	`159`	`+ snprintf(buf, sizeof(buf), "%s", "\n\r <> The world starts spinning <>\n\r");`
`160`	`160`
`161`	`161`	`/* For each playing descriptor, save its state */`
`162`	`162`	`AttachIterator(&Iter, dsock_list);`