Bcryp improvement (#22)

* Move va_end closer to va_start

* Remove unsafe strncpy and use safer snprintf.

* Add openwall bcrypt library.

* Removing the old crypt library.

* Clean up mud.h to include new crypto library include

* Updated Makefile to include new crypt library

* Small change to mud.h to add the right path to include ow-crypt.h

* Added a test case to check the new bcrypt library works.

* Added another test for the new bcrypt that must fail to pass.

* Change all calls to crypt to correctly use the new API.

* Some macOS rubbish that we don't want tracked into git.

* Change a C++ comment to C so it can compile in Linux.

Author: rogersm

.gitignore

@@ -4,5 +4,7 @@ guildmud
 .vscode/tasks.json
 *.log
 .vscode/settings.json
-src/libguildmud.a
-tests/*.run
+libguildmud.a
+libblowfish-1.3.a
+*.run
+Info.plist

Makefile

@@ -9,8 +9,8 @@ OBJ_FILES = $(filter-out src/main.o, $(SRC_FILES:.c=.o))
 CHECK_FILES = $(wildcard tests/*.test)
 CHECK_FILES_EXE = $(CHECK_FILES:.test=.run)
 
-all: src/main.o src/libguildmud.a
-	@$(CC) -o src/guildmud src/main.o src/libguildmud.a $(L_FLAGS)
+all: src/main.o src/libguildmud.a src/crypt_blowfish-1.3-mini/libblowfish-1.3.a
+	@$(CC) -o src/guildmud src/main.o src/libguildmud.a src/crypt_blowfish-1.3-mini/libblowfish-1.3.a $(L_FLAGS)
 
 src/libguildmud.a: $(OBJ_FILES)
 	@ar ru $@ $^
@@ -25,7 +25,7 @@ test: $(CHECK_FILES_EXE)
 
 
 tests/%.run: tests/%.c src/libguildmud.a
-	@$(CC) -o $@ $< src/libguildmud.a $(C_FLAGS_TEST) $(L_FLAGS_TEST) 
+	@$(CC) -o $@ $< src/libguildmud.a src/crypt_blowfish-1.3-mini/libblowfish-1.3.a $(C_FLAGS_TEST) $(L_FLAGS_TEST) 
 	# $@ -- Uncomment if we want to run the compiled test
 
 tests/%.c: tests/%.test
@@ -38,3 +38,32 @@ install:
 clean:
 	@echo Cleaning code ...
 	@rm -rf src/*.o src/guildmud src/libguildmud.a src/*~ tests/*.c tests/run* tests/*.dSYM src/*.dSYM
+	@rm -rf src/crypt_blowfish-1.3-mini/*.o src/crypt_blowfish-1.3-mini/*~ src/crypt_blowfish-1.3-mini/*a src/crypt_blowfish-1.3-mini/mini-test
+
+# Blowfish compilation rules
+
+AS = $(CC)
+LD = $(CC)
+BFISH_CFLAGS = -g -W -Wall -Wbad-function-cast -Wcast-align -Wcast-qual -Wmissing-prototypes -Wstrict-prototypes -Wshadow -Wundef -Wpointer-arith -O2 -fomit-frame-pointer -funroll-loops
+BFISH_ASFLAGS = -c
+BFISH_LDFLAGS = -sL
+
+CRYPT_OBJS = src/crypt_blowfish-1.3-mini/crypt_blowfish.o \
+			 src/crypt_blowfish-1.3-mini/crypt_gensalt.o \
+			 src/crypt_blowfish-1.3-mini/wrapper.o
+
+crypt: src/crypt_blowfish-1.3-mini/libblowfish-1.3.a src/crypt_blowfish-1.3-mini/mini-test
+
+src/crypt_blowfish-1.3-mini/libblowfish-1.3.a: $(CRYPT_OBJS)
+	@ar ru $@ $^
+	@ranlib $@
+
+src/crypt_blowfish-1.3-mini/mini-test: src/crypt_blowfish-1.3-mini/mini-test.o src/crypt_blowfish-1.3-mini/libblowfish-1.3.a
+	$(CC) -o $@ $< $(L_FLAGS) src/crypt_blowfish-1.3-mini/libblowfish-1.3.a
+
+src/crypt_blowfish-1.3-mini/crypt_blowfish.o: src/crypt_blowfish-1.3-mini/crypt_blowfish.h
+src/crypt_blowfish-1.3-mini/crypt_gensalt.o: src/crypt_blowfish-1.3-mini/crypt_gensalt.h
+src/crypt_blowfish-1.3-mini/wrapper.o: src/crypt_blowfish-1.3-mini/crypt.h src/crypt_blowfish-1.3-mini/ow-crypt.h \
+										 src/crypt_blowfish-1.3-mini/crypt_blowfish.h src/crypt_blowfish-1.3-mini/crypt_gensalt.h
+
+