Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release custom JUCE changes as standalone repo #16

Open
falkTX opened this issue Mar 2, 2021 · 2 comments
Open

Please release custom JUCE changes as standalone repo #16

falkTX opened this issue Mar 2, 2021 · 2 comments

Comments

@falkTX
Copy link

falkTX commented Mar 2, 2021

Hi there.
While packaging vital as vitalium, I noticed that there are a few issues present on the custom version that are not in the original.
I was told there is at least this patch applied in vital https://gist.github.com/wrl/240050fd46e14b688551c75ed2700076
There is also custom APIs that you added on top of JUCE.

Issue is, it is very hard at the moment to know what changes you made, much less reasons for doing so.
Please consider making a repo for tracking your juce changes. Or better, as I expect you do already have such a repo, please make it public. Thanks

@falkTX falkTX changed the title Please release custom JUCE change as standalone repo Please release custom JUCE changes as standalone repo Mar 2, 2021
@mtytel
Copy link
Owner

mtytel commented Mar 2, 2021

Ehh... yeah I can release this. I'll need a bit to make sure there aren't changes that can't be public but I think it's fine.
I really tried keeping JUCE intact but at some point there were things I had to change to make my UI system work.

@falkTX
Copy link
Author

falkTX commented Mar 2, 2021

Thank you. I considered checking out the changes manually, but on 2nd thought it seems like it will be really tough, plus I wont really understand any reason why something was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants