Sort with defaults #215
Merged
Sort with defaults #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mthadley#18 by allowing sort when properties have a default, as long as none of the identifiers in the default match one of the properties being destructured.
mthadley
requested changes
Jan 20, 2023
There was a problem hiding this comment.
Thanks, @ianobermiller!
This is looking great, and it's encouraging to hear that it's already working on a large codebase without any problems. Left a few comments for cleanup, after which we can get this merged.
Break out functions. adjust switch. rename var in tests
mthadley
approved these changes
Feb 15, 2023
|
Thanks again for the contribution! These changes have been published in |
This was referenced Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18 by allowing sort when properties have a default, as long as none of the identifiers in the default match one of the properties being destructured. Besides the tests here, we also ran this on a 10k+ file codebase here at Netflix and found zero issues.