Bump Java Version to 17/25 (LearnLib#97)

* initial refactorings for Java 25 compatibility

spotbugs + pmd-plugin still need new releases that work on Java 25

* update CI config

* JDK builds pass

updates to the analysis plugins required some adjustments

* utilize Java 17 features

* fix documentation

* cleanups

* fix visibility issues

* potential fix for breaking GUI tests

* example: fix GUI tests

* cleanups

* jung: do not run GUI tests for now

* Revert "jung: do not run GUI tests for now"

This reverts commit 6a66454.

* jung: found workaround for crashing JVM

* jacoco: correctly track coverage in GUI tests

* Revert "jung: found workaround for crashing JVM"

This reverts commit d997040.

* Reapply "jung: do not run GUI tests for now"

This reverts commit 176cece.

* jung: add note

Author: mtf90

.github/workflows/ci.yml

@@ -12,7 +12,7 @@ jobs:
     name: "Tests and Analysis (JDK: ${{ matrix.jdk }})"
     strategy:
       matrix:
-        jdk: [ 11, 17, 21 ]
+        jdk: [ 17, 21, 25 ]
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -45,7 +45,7 @@ jobs:
     needs: [ tests-and-analysis ]
     strategy:
       matrix:
-        jdk: [ 11, 17, 21 ]
+        jdk: [ 17, 21, 25 ]
         os: [ ubuntu-latest, windows-latest, macos-13, macos-latest ]
     runs-on: ${{ matrix.os }}
     steps:
@@ -77,7 +77,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           distribution: 'zulu'
-          java-version: 11
+          java-version: 17
       - name: Set up cache
         uses: actions/cache@v4
         with:
@@ -117,7 +117,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           distribution: 'zulu'
-          java-version: 11
+          java-version: 17
       - name: Set up cache
         uses: actions/cache@v4
         with:

CHANGELOG.md

@@ -13,14 +13,26 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ### Changed
 
-* AutomataLib now requires Java 11 at runtime.
+* AutomataLib now requires Java 17 at runtime.
+* The following classes have been refactored to `record`s:
+  * `BricsTransitionProperty`
+  * `TransitionEdge{,.Property}`
+  * `ProbabilisticOutput`
+  * `LTSminVersion`
+* The following class hierarchies have been made `sealed`:
+  * `CommonAttrs`
+  * `CommonStyles`
 * `ProcessUtil#invokeProcess` now handles consumers for stdout and stderr separately.
 
 ### Removed
 
 * `IOUtil#copy(Reader, Writer)` has been removed. Use `Reader#transferTo(Writer)` instead.
 * `JVMUtil` has been removed. Use `Runtime.version().feature()` for its previously (only) provided method.
 
+### Fixed
+
+* `SPAConverter.ConversionResult` is now publicly accessible.
+
 
 ## [0.12.1] - 2025-03-11
 

README.md

@@ -31,7 +31,7 @@ Contributions -- whether it is in the form of new features, better documentation
 
 For simply using AutomataLib you may use the Maven artifacts which are available in the [Maven Central repository][maven-central].
 It is also possible to download a bundled [distribution artifact][maven-central-distr] if you want to use AutomataLib without Maven support.
-Note that AutomataLib requires Java 11 (or newer) to build and run.
+Note that AutomataLib requires Java 17 (or newer) to build and run.
 
 #### Building development versions
 

adapters/brics/src/main/java/net/automatalib/brics/BricsTransitionProperty.java

@@ -16,15 +16,16 @@
 package net.automatalib.brics;
 
 import dk.brics.automaton.Transition;
-import org.checkerframework.checker.nullness.qual.Nullable;
 
 /**
  * The properties of an edge in a Brics automaton.
+ *
+ * @param min
+ *         lower bound of the character range.
+ * @param max
+ *         upper bound of the character range.
  */
-public class BricsTransitionProperty {
-
-    private final char min;
-    private final char max;
+public record BricsTransitionProperty(char min, char max) {
 
     /**
      * Constructor. Constructs the property from a Brics {@link Transition}.
@@ -36,41 +37,6 @@ public BricsTransitionProperty(Transition trans) {
         this(trans.getMin(), trans.getMax());
     }
 
-    /**
-     * Constructor.
-     *
-     * @param min
-     *         lower bound of the character range.
-     * @param max
-     *         upper bound of the character range.
-     */
-    public BricsTransitionProperty(char min, char max) {
-        this.min = min;
-        this.max = max;
-    }
-
-    /**
-     * Retrieves the lower bound of the character range.
-     *
-     * @return the lower bound of the character range
-     *
-     * @see Transition#getMin()
-     */
-    public char getMin() {
-        return min;
-    }
-
-    /**
-     * Retrieves the upper bound of the character range.
-     *
-     * @return the upper bound of the character range
-     *
-     * @see Transition#getMax()
-     */
-    public char getMax() {
-        return max;
-    }
-
     @Override
     public String toString() {
         return toString(min, max);
@@ -84,25 +50,4 @@ public static String toString(char min, char max) {
         }
         return sb.toString();
     }
-
-    @Override
-    public final boolean equals(@Nullable Object o) {
-        if (this == o) {
-            return true;
-        }
-        if (!(o instanceof BricsTransitionProperty)) {
-            return false;
-        }
-
-        final BricsTransitionProperty that = (BricsTransitionProperty) o;
-        return min == that.min && max == that.max;
-    }
-
-    @Override
-    public final int hashCode() {
-        int result = 1;
-        result = 31 * result + Character.hashCode(min);
-        result = 31 * result + Character.hashCode(max);
-        return result;
-    }
 }

api/src/main/java/net/automatalib/alphabet/Alphabet.java

@@ -125,8 +125,8 @@ default boolean containsSymbol(I symbol) {
      *         if {@code this} alphabet does not implement {@link GrowingAlphabet}
      */
     default GrowingAlphabet<I> asGrowingAlphabetOrThrowException() {
-        if (this instanceof GrowingAlphabet) {
-            return (GrowingAlphabet<I>) this;
+        if (this instanceof GrowingAlphabet<I> result) {
+            return result;
         } else {
             throw new GrowingAlphabetNotSupportedException(this);
         }

api/src/main/java/net/automatalib/alphabet/SupportsGrowingAlphabet.java

@@ -23,6 +23,7 @@
  * @param <I>
  *         input alphabet type
  */
+@FunctionalInterface
 public interface SupportsGrowingAlphabet<I> {
 
     /**

api/src/main/java/net/automatalib/automaton/concept/FiniteRepresentation.java

@@ -23,6 +23,7 @@
  * {@link SimpleAutomaton}). For example, push-down systems can have infinitely many states but may be representable
  * with a finite amount of locations.
  */
+@FunctionalInterface
 public interface FiniteRepresentation {
 
     /**

api/src/main/java/net/automatalib/automaton/concept/InputAlphabetHolder.java

@@ -17,6 +17,7 @@
 
 import net.automatalib.alphabet.Alphabet;
 
+@FunctionalInterface
 public interface InputAlphabetHolder<I> {
 
     Alphabet<I> getInputAlphabet();

api/src/main/java/net/automatalib/automaton/concept/Output.java

@@ -28,15 +28,16 @@
  * @param <D>
  *         output domain type
  */
+@FunctionalInterface
 public interface Output<I, D> {
 
     D computeOutput(Iterable<? extends I> input);
 
     static <T> WordBuilder<T> getBuilderFor(Iterable<?> iterable) {
-        if (iterable instanceof Word) {
-            return new WordBuilder<>(((Word<?>) iterable).length());
-        } else if (iterable instanceof Collection) {
-            return new WordBuilder<>(((Collection<?>) iterable).size());
+        if (iterable instanceof Word<?> w) {
+            return new WordBuilder<>(w.length());
+        } else if (iterable instanceof Collection<?> c) {
+            return new WordBuilder<>(c.size());
         } else {
             return new WordBuilder<>();
         }

api/src/main/java/net/automatalib/automaton/concept/Probabilistic.java

@@ -15,6 +15,7 @@
  */
 package net.automatalib.automaton.concept;
 
+@FunctionalInterface
 public interface Probabilistic<T> {
 
     float getTransitionProbability(T transition);