[pull] master from jupyter-server:master #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
|
Hey! Changelogs info seems to be missing or might be in incorrect format. |
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 77.63% 77.76% +0.13%
==========================================
Files 105 106 +1
Lines 8964 9269 +305
Branches 956 997 +41
==========================================
+ Hits 6959 7208 +249
- Misses 1666 1706 +40
- Partials 339 355 +16
Continue to review full report at Codecov.
|
Ensure jupyter config dir exist
currently, all errors in pre_save_hook are ignored, making it impossible for pre_save_hook to be used for validation / quota enforcement / etc. By allowing HTTPErrors to raise, save will be cancelled and the error message will be shown to the user
allow pre_save_hook to cancel save with HTTPError
Changelog for 1.5.1
Update MappingKM.restart_kernel to accept now kwarg
Add descriptive log for port unavailable and port-retries=0
Before this PR, the default output of server urls looks like:
Or copy and paste one of these URLs:
http://localhost:8888/?token=…
or http://127.0.0.1:8888/?token=…
This makes it easy to triple-click on the first line to copy and paste it into a browser. However, triple-clicking on the second line picks up the extra “or”, so you can’t just copy and paste it into the browser. Instead, you have to explicitly select each character by dragging your mouse, avoiding the “or”.
This change deletes the “or” so you can just triple-click on the second line to copy and paste the url.
Delete the extra “or” that prevents easy cut-and-paste of URLs.
Add support for JUPYTER_TOKEN_FILE
Add env variable support for port options
Update description for kernel restarted in the API docs
Remove unnecessary future imports
Add Changelog to Sphinx Docs
* bug fixing allow_origin_pat property * making requested changes
* Remove direct use of logging to keep log format consistent * Add missing log for failed server info file deletion * Add missing null check * Remove unused import: logging
* enforce labels on PRs * Update enforce-label.yml * Update enforce-label.yml
avoids collisions across a given host
test_list_notebooks was failing on file systems with unicode normalization different from the encoding used in the strings. In particular on macOS with HFS+ I got failures for four of the file names. This is because HFS+ uses normalization form D while normalization form C is more commonly used, especially on Linux. By normalizing the name and path read from disk to NFC we avoid the mismatch as long as no NFD strings are added to the `dirs` tuples. There are other unicode normal forms and normalization is not necessarily invertible so this is not a perfect solution. I can think of two alternative solutions: 1. Refrain from using any unicode symbols that have different representations in the various normal forms. 2. Write temporary files to disk somewhere, the read back the paths and filenames and use those instead of the original strings in the test.
* wip use pending kernels yup wip wip handle getattr use ensure_future add more backwards compat clean up tests more cleanup Fix ping handling for shut down kernels fix handling of kernel startup lint * fix handling of kernel activity * clean up pre-commit * make tests less brittle * make tests less brittle Co-authored-by: Steven Silvester <ssilvester@apple.com>
* Automated Changelog Entry for 1.12.0 on master * Update CHANGELOG.md Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com>
SHA256 hashes: jupyter_server-1.12.0-py3-none-any.whl: b1f4a11a5a68f8aa4748e172e7b7789fa870f98b9b11f95f7530ea9ef581626c jupyter_server-1.12.0.tar.gz: 0d8ab06f34e1cad224373e3b127e07d9cbb48babd66286136fbd075ce509b6ff
* await _finish_kernel_start * Guard with use_pending_kernels
* Update to Python 3.10 in the CI workflows * Lint
* Automated Changelog Entry for 1.12.1 on master * Update CHANGELOG.md Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com>
SHA256 hashes: jupyter_server-1.12.1-py3-none-any.whl: 93a84d06c35613ecf3bc5de8ff2d92a410a3a5f57a3a23444ca75e4b2b390209 jupyter_server-1.12.1.tar.gz: f71e10ebaa6704a1e0fe76ec70a16a0804ab5a9d268f0c512e8c69086a8e86d1
* use tbump fields * add version template * fix name * Update pyproject.toml
* clean up downstream tests * syntax * use new extra_test * no unit tests * fix option name
* allow the session manager to persist on disk * validate the filepath given to a persistent session manager and add unit tests * update help string * finish comments in unit test * precommit cleanup * allow empty session datbase file
Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com>
SHA256 hashes: jupyter_server-1.13.0-py3-none-any.whl: 608c0cb0cbbaa96a413c4d2427ca77acd14180251a2687831cf31f7648eaa835 jupyter_server-1.13.0.tar.gz: 05a96dfc5352adf70e88868b4ab3d1fc13e17bd84daf74d02cc6299098855fda
Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com>
SHA256 hashes: jupyter_server-1.13.1-py3-none-any.whl: abfe55b6cd7bac0d7d7b8042765b7e451f11b5f2276a2ad708745cd8904d4e5b jupyter_server-1.13.1.tar.gz: 6d70ebf8e789a7d0a5cd1588e078ccbbdca388dc2c74a6cd62b9ebb80609344f
significant time savings in pre-commit pylint was only checking for one issue, which flake8 supports, but skipped remove the skip in flake8 config, so pylint can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )