WIN-4504 | Remove notices from Slack ext/json patches (facebook#114)

ext/json contains a set of temporary patches for backwards compatibility
with the jsonc parser, emitting notices when input is encountered that
would fail to parse were it not for these patches.
However, almost every call to `json_decode_mixed` in webapp is conveniently
prefixed with the error silence operator `@`, so we don't really hear from
them much. So, remove the notices outright. If we ever want to invest into
removing the patches, we can implement the logging in a different way.

Author: mszabo-wikia

hphp/runtime/ext/json/JSON_parser.cpp

@@ -1328,15 +1328,7 @@ bool JSON_parser(Variant &z, const char *p, int length, bool const assoc,
     // Fast-case most common transition: append a simple string character.
     if (state == 3 && type == KindOfString) {
       while (b != '\"' &&  b != '\\' && b != '\'' && b <= 127 && (b >= ' ' || b == '\n' || b == '\t')) {
-        // @slack temporary patch to remove USE_JSONC
-        if (b == '\n') {
-          raise_notice("Slack json_decode patch - temporarily allowing newline in json for backwards compatibility");
-        }
-
-        // @slack temporary patch to remove USE_JSONC
-        if (b == '\t') {
-          raise_notice("Slack json_decode patch - temporarily allowing tab in json for backwards compatibility");
-        }
+        // @slack temporary patch accepting newlines and tabulators to remove USE_JSONC
         buf->append((char)b);
         b = decoder.decode();
       }

hphp/runtime/ext/json/ext_json.cpp

@@ -228,7 +228,6 @@ TypedValue HHVM_FUNCTION(json_decode, const String& json,
     const auto loose_ok =
       JSON_parser(z, json.data(), json.size(), assoc, depth, parser_options);
     if (loose_ok) {
-      raise_notice("Slack json_decode patch - implicitly applied JSON_FB_LOOSE for more permissive parsing after json_decode failure");
       return tvReturn(std::move(z));
     }
   }
@@ -299,9 +298,6 @@ TypedValue HHVM_FUNCTION(json_decode, const String& json,
   // @slack: commented out section is a temporary patch
   if (/*(options & k_JSON_FB_LOOSE) &&*/ json.size() > 1 &&
       ch0 == '\'' && json.charAt(json.size() - 1) == '\'') {
-    if (!(options & k_JSON_FB_LOOSE)) {
-      raise_notice("Slack json_decode patch - temporarily allowing single quoted json keys for JSON_C backwards compatibility");
-    }
     json_set_last_error_code(json_error_codes::JSON_ERROR_NONE);
     return tvReturn(json.substr(1, json.size() - 2));
   }