Skip to content

Commit 1f36173

Browse files
mszabo-wikiaGitHub Enterprise
authored andcommitted
Remove internal type from __Sealed attribute in implicit_context.hhi (facebook#116)
D74667088 marked MemoSensitiveImplicitContext as __Sealed, with only a single class permitted to directly extend it. This class is however internal to Meta, causing typechecking errors in OSS Hack. So, comment these out to mimic what facebook#9626 will (hopefully) do in upstream once it lands.
1 parent c795cc8 commit 1f36173

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

hphp/hack/hhi/implicit_context.hhi

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ namespace HH {
3535

3636
} // namespace ImplicitContext
3737

38-
<<__Sealed(FBMemoAgnosticImplicitContext::class)>>
38+
// Avoid referencing an internal class in OSS.
39+
// <<__Sealed(FBMemoAgnosticImplicitContext::class)>> // @oss-disable
3940
abstract class MemoAgnosticImplicitContext extends ImplicitContextBase {
4041
final protected static async function runWithAsync<Tout>(
4142
this::TData $context,
@@ -48,7 +49,8 @@ namespace HH {
4849
)[this::CRun, ctx $f]: Tout;
4950
}
5051

51-
<<__Sealed(FBMemoSensitiveImplicitContext::class)>>
52+
// Avoid referencing an internal class in OSS.
53+
// <<__Sealed(FBMemoSensitiveImplicitContext::class)>> // @oss-disable
5254
abstract class MemoSensitiveImplicitContext extends ImplicitContextBase {
5355
abstract const type TData as IPureMemoizeParam;
5456

0 commit comments

Comments
 (0)