-
-
Notifications
You must be signed in to change notification settings - Fork 217
Add Control Flow Guard support #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Control Flow Guard support #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking extremely good overall, thanks! I've only got a couple minor details to discuss.
3c06b8f
to
584ddde
Compare
584ddde
to
fb92119
Compare
Thanks, I have addressed the comments. Let's wait and see how the actions https://github.com/alvinhochun/llvm-mingw/actions/runs/3158626818 and https://github.com/alvinhochun/llvm-mingw/actions/runs/3158634041 go. |
Thanks! Can you kick off another actions run, with a branch on top of this which bumps llvm/mingw to versions that support it, and which enables it by default even for non-scheduled runs, to see it in action? |
https://github.com/alvinhochun/llvm-mingw/actions/runs/3158634041 does use the latest versions of llvm and mingw-w64 (the get-versions version check is enabled) and has cfguard enabled. |
These test runs seem to have run successfully - so, I guess there's nothing left stopping this from getting merged then? |
Not from me! |
Great! I did some extra test runs with Wine (with run-tests.sh tweaked to actually run the failure tests there too), and it worked as expected ( |
Adds the option to build with Control Flow Guard support. This is disabled by default and currently only enabled for the scheduled GitHub Actions build because it requires latest LLVM 16 and mingw-w64. We should change the default to enabled for the next release.
Closes #301