-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The deployed module doesn't seem to follow current nodejs conventions #1
Comments
Specifically, if you want the package to be requireable/importable, you need to specify "main" and "exports". |
This module was produced by wasm-pack, and I think I even filed this very bug at some point: rustwasm/wasm-pack#94 |
Updating the dependencies and building with |
@ljharb I've published 0.3.0 with the main file now being named |
You don't really need the "exports" field here, because in this case there's only one .js file in the package. It looks fine to me, but it really should include |
Thanks for the feedback! I filed rustwasm/wasm-pack#1009 on that. However, given the current maintainership status of wasm-pack, it probably won't see any action any time soon. I'll adjust the package.json manually in the meantime. |
Ok, fixed in https://unpkg.com/browse/gecko-profiler-demangle@0.3.1/ . |
Thanks for the quick update @mstange :-) |
See import-js/eslint-plugin-import#2098 (comment) for more insight.
The text was updated successfully, but these errors were encountered: