Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/scenario testing for metaVaults #39

Open
2 of 9 tasks
tushargargght opened this issue Oct 4, 2022 · 1 comment
Open
2 of 9 tasks

issue/scenario testing for metaVaults #39

tushargargght opened this issue Oct 4, 2022 · 1 comment
Labels
contract Contract work v2 mStable v2 roadmap

Comments

@tushargargght
Copy link
Contributor

tushargargght commented Oct 4, 2022 •
edited
Loading

Finding and implementing missing scenarios/tests for integration

Missing Scenarios

  • add _afterRemoveVault hook to SameAssetsUnderlyingAVbstractVault #68
  • update assetsPerShare in _afterAddVault hook for PeriodicAllocationAbstractVault
  • Create behavior for PerfFeesAbstractVault
  • PerdiodicAllocationPerfFeesMetaVault update assetsPerShare in following
    • after Rebalance
    • after settle
    • after charge Performmance fees
    • after removeVault
  • use PerfFeeAbstractVault behavior in PerdiodicAllocationPerfFeesMetaVault

Scenario analysis remaining for Convex3CrvLiquidatorVault
@tushargargght tushargargght mentioned this issue Oct 4, 2022
Merged
5 tasks
@naddison36 naddison36 added contract Contract work v2 mStable v2 roadmap labels Oct 4, 2022
@tushargargght tushargargght changed the title issue/create PerfFeesBehavior and PeriodicAllocationAbstractVaultBehavior and assertPerShare update tests for PeriodicAllocationPerfFeeMetaVault issue/scenario testing for metaVaults Oct 26, 2022
@tushargargght tushargargght self-assigned this Oct 26, 2022
@tushargargght
Copy link
Contributor Author

As discussed, will implement #68 and park this issue for now.

@doncesarts doncesarts assigned doncesarts and unassigned doncesarts Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contract Contract work v2 mStable v2 roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@naddison36 @doncesarts @tushargargght